Add support for entropy device - #24
Conversation
There was a problem hiding this comment.
I'm not an expert of this crate but LGTM. Final approval should be given by @mkroening
mkroening
left a comment
mkroening
left a comment
There was a problem hiding this comment.
Sorry for the wait. :)
Thanks for opening the PR.
Since the spec (Entropy device) does not define any feature bits or a device configuration layout, I think we should not add any empty placeholder types here.
Marking the device as supported is fine, but I think we should remove all code additions. Kernels can just use virtio::F for the features and () for the config if they need to specify a type. Depending on the kernel architecture, such a type might not be necessary, though, hence my hesitance to add them.
What do you think?
|
Marking the entropy device as supported while no explicit support is there might be confusing. |
3 participants
No description provided.